Remove all version checks for Java 6 and 7 #14006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
requested changes
Apr 27, 2024
codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyHeaderBlockZlibEncoder.java
Outdated
Show resolved
Hide resolved
Motivation: Netty 4.2 now requires Java 8 as the minimum supported version, so there is no need to guard for older JDKs. Modification: Remove all the version checks for Java 7 and older, and remove all uses of `@SuppressJava6Requirement`. Revapi complains these annotation removals are a potential compatibility issue, so ignores have been added. Result: Less code dealing with JDK versions.
It detects a binary incompatibility when compiled with newer JDKs.
chrisvest
force-pushed
the
4.2-all-java-8-or-better
branch
from
d282fb9
to
26e953f
Compare
|
@normanmaurer Addressed comments and rebased. |
|
@chrisvest thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Netty 4.2 now requires Java 8 as the minimum supported version, so there is no need to guard for older JDKs.
Modification:
Remove all the version checks for Java 7 and older, and remove all uses of
@SuppressJava6Requirement. Revapi complains these annotation removals are a potential compatibility issue, so ignores have been added.Result:
Less code dealing with JDK versions.