Add no-value key handling only for form body #13998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This is a fix for issue netty#13981 that reports a changed behaviour of HttpPostStandardRequestDecoder after this PR - netty#13908 Because HttpPostStandardRequestDecoder changed the contract, some code implementations relying on certain parsing are failing Modification: This PR makes sure, that the edge case handling for form data happenes only when the content is in fact form data Result: Fixes netty#13981
normanmaurer
requested changes
Apr 23, 2024
.../src/test/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoderTest.java
Outdated
Show resolved
Hide resolved
normanmaurer
requested changes
Apr 27, 2024
...http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java
Outdated
Show resolved
Hide resolved
...http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java
Outdated
Show resolved
Hide resolved
normanmaurer
approved these changes
Apr 27, 2024
|
@gniadeck thanks! |
normanmaurer
pushed a commit
that referenced
this pull request
Apr 27, 2024
Motivation: This is a fix for issue #13981 that reports a changed behaviour of HttpPostStandardRequestDecoder after this PR - #13908 Because HttpPostStandardRequestDecoder changed the contract, some code implementations relying on certain parsing are failing Modification: This PR makes sure, that the edge case handling for form body happenes only when the content is in fact form body Result: Fixes #13981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This is a fix for issue #13981 that reports a changed behaviour of HttpPostStandardRequestDecoder after this PR - #13908
Because HttpPostStandardRequestDecoder changed the contract, some code implementations relying on certain parsing are failing
Modification:
This PR makes sure, that the edge case handling for form body happenes only when the content is in fact form body
Result:
Fixes #13981