Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SocketHalfClosedTest for epoll #13025

Merged
merged 2 commits into from Nov 29, 2022
Merged

Enable SocketHalfClosedTest for epoll #13025

merged 2 commits into from Nov 29, 2022

Commits on Nov 28, 2022

  1. Enable SocketHalfClosedTest for epoll 

    Motivation:
These tests were not being run for epoll because the classes did not have the Test suffix.
We also aren't regularly running these tests for kqueue because we don't have a MacOS CI build.
It turns out that all transports now behave consistently with regards to read-completes after input shutdown, so the tests don't need to change their assertions for epoll/kqueue vs. NIO.

Modification:
Enable the SocketHalfClosedTest for epoll, both edge and level triggered.
Remove test parameter adjustments for epoll and kqueue.

Result:
SocketHalfClosedTest tests now run, and pass, for epoll.
    @chrisvest
    chrisvest committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    fe4ded2 View commit details
    Browse the repository at this point in the history

  2. Remove timeout to make revapi happy 

    Although, this really should not be part of the public API.
    @chrisvest
    chrisvest committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    b599598 View commit details
    Browse the repository at this point in the history