Add API to allow custom Stream ID creation in Http2FrameCodec
#13007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperxpro
changed the title
Http2FrameCodec
|
Can you tell me why we need this ? What's the use-case ? |
|
For proxy, I have to manually create streams with custom IDs so I can save and track them ahead of sending them down to pipeline. |
|
@hyperxpro is this still required ? |
|
Yes, actually. Let me make this reviewable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In some use cases, we need to pass a custom stream ID and currently, the
Http2FrameCodeclack API to use a custom stream ID. It is generated byHttp2Connection#Endpointautomatically.Modification:
Added API to use custom stream ID.
Result:
Add API to allow manual Stream ID creation