Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save promises type pollution due to interface type checks #12980

Merged
merged 2 commits into from Nov 29, 2022
Merged

Save promises type pollution due to interface type checks #12980

merged 2 commits into from Nov 29, 2022

Commits on Nov 9, 2022

  1. Save promises type pollution due to interface type checks 

    Motivation:

DefaultPromise performs interfaces type checks to distinguish single/multi listeners presence, hitting https://bugs.openjdk.org/browse/JDK-8180450

Modifications:

Using separate listener fields that won't require type checks to evaluate listeners arity

Result:
No type pollution for user-defined listeners types.
    @franz1981
    franz1981 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    91d137f View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Apply suggestions from code review

    @normanmaurer
    normanmaurer committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    465a599 View commit details
    Browse the repository at this point in the history