Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing HTTP/2 requests with upgrade-insecure-requests #12799

Merged
merged 1 commit into from Sep 13, 2022

Commits on Sep 13, 2022

  1. Avoid failing HTTP/2 requests with upgrade-insecure-requests

    Motivation:
    This is a non-standard header that is not _explicitly_ called out as connection related, even though it can be argued that it is.
    Regardless, Chrome and Firefox do actually send this header in their HTTP/2 requests, so rejecting these is quite troublesome.
    Safari doesn't send this header.
    
    Modification:
    Remove the check for `upgrade-insecure-requests` in the header validation in HpackDecoder.
    Also update tests to match.
    
    Result:
    HTTP/2 requests from Chrome and Firefox are no longer rejected by the header validation.
    
    Fixes netty#12798
    chrisvest committed Sep 13, 2022
    Copy the full SHA
    1d33e17 View commit details
    Browse the repository at this point in the history