Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent synchronization of PoolSubpage.doNotDestroy #12775

Merged
merged 1 commit into from Sep 7, 2022
Merged

Fix inconsistent synchronization of PoolSubpage.doNotDestroy #12775

merged 1 commit into from Sep 7, 2022

Commits on Sep 6, 2022

  1. Fix inconsistent synchronization of PoolSubpage.doNotDestroy 

    Motivation:
This field is modified under lock, and thus should not be accessed (toString excepted) without locking.

Modification:
Move an assert check on PoolSubpage.doNotDestroy into a nearby critical region.

Also encapsulate the findSubpagePoolHead logic better; PoolArena now always use this method instead of that one place that was accessing the array directly.
This should not have any influence on the logic.

Result:
Assert in PoolChunk is no longer racy.
    @chrisvest
    chrisvest committed Sep 6, 2022
    Copy the full SHA
    21dce55 View commit details
    Browse the repository at this point in the history