Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isOriginForm and isAsteriskForm #12568

Merged
merged 2 commits into from Jul 8, 2022
Merged

Fix isOriginForm and isAsteriskForm #12568

merged 2 commits into from Jul 8, 2022

Commits on Jul 6, 2022

  1. Fix isOriginForm and isAsteriskForm

    These methods would always return false using the previously implementation (URI#getSchemeSpecificPart is documented to *never* return `null`). They also had other implementation errors. Correct these and make sure they at least handle the basic examples provided in RFC 7230. More test cases can be added as needed.
    jkjk822 committed Jul 6, 2022
    Copy the full SHA
    1c854a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Simplify isOriginForm and isAsteriskForm Further

    Reduce these methods to string comparisons, and add overrides that take strings directly.
    Use these new methods where we had previously switched to string comparison directly.
    jkjk822 committed Jul 7, 2022
    Copy the full SHA
    5524503 View commit details
    Browse the repository at this point in the history