Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Better Path Handling #12533

Merged
merged 4 commits into from Jul 2, 2022
Merged

Add Better Path Handling #12533

merged 4 commits into from Jul 2, 2022

Commits on Jun 29, 2022

  1. Add Better Path Handling

    Directly forward the uri when it's a path instead of trying to parse it.
    
    Also clean up isOriginForm/isAsteriskForm as their logic seems to be incorrect (for example, URI#getSchemeSpecificPart() never returns null so they both return false trivially). They should probably be edited themselves in a later commit (and possibly used again here when correct). Since this was always returning true, it's unclear if authority logic is still correct after this change.
    jkjk822 committed Jun 29, 2022
    Copy the full SHA
    2d7f5bd View commit details
    Browse the repository at this point in the history
  2. Add Tests

    Add tests to ensure request conversion behaves as expected.
    jkjk822 committed Jun 29, 2022
    Copy the full SHA
    3f18a02 View commit details
    Browse the repository at this point in the history
  3. Fix Typo in Test

    jkjk822 committed Jun 29, 2022
    Copy the full SHA
    e7e2643 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Fix Test Failures

    Fix test failures. This requires refactoring the authority pathway to
    reflect what it was in practice before (though not what the logic
    implied).
    
    Specifically, the logic before never set the HTTP2 Authority if the path
    was in origin or asterisk form (although due to those methods always
    returning false this never affected output).
    jkjk822 committed Jun 30, 2022
    Copy the full SHA
    b705c3b View commit details
    Browse the repository at this point in the history