Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exceptions when rule violating UDS paths been passed in. #11663

Merged
merged 1 commit into from Sep 8, 2021
Merged

Throw exceptions when rule violating UDS paths been passed in. #11663

merged 1 commit into from Sep 8, 2021

Commits on Sep 4, 2021

  1. Throw exceptions when rule violating UDS paths been passed in. 

    Motivation:

Currently, Netty is silently truncating all over the limit UDS paths and ignoring the `sun_path`'s null-termination role, which hurts compatibility with other UDS clients and servers.

Modifications:

Adding a validation in the JNI code, if the UDS path is not satisfying the system limit or Linux spec throw a NativeIoException.

Result:

All UDS paths Netty can successfully bind are connectable by other programs.
    @ran-su
    ran-su committed Sep 4, 2021
    Copy the full SHA
    7d27aff View commit details
    Browse the repository at this point in the history