Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect jdk.tls.namedGroups when using native SSL implementation #11660

Merged
merged 6 commits into from Sep 9, 2021
Merged

Respect jdk.tls.namedGroups when using native SSL implementation #11660

merged 6 commits into from Sep 9, 2021

Commits on Sep 7, 2021

  1. Respect jdk.tls.namedGroups when using native SSL implementation 

    Motivation:

When using the JDK implementation for SSL its possible to adjust the used named groups. We should allow to do this as well and also select some default groups that will reduce the number of roundtrips.

Modifications:

- Upgrade netty-tcnative so we can set the curves
- Respect jdk.tls.namedGroups
- Use default groups of "P-256", "P-384", "X25519" so its compatible with what the JDK versions < 13 support as well.

Result:

Be able to set the used groups
    @normanmaurer
    normanmaurer committed Sep 7, 2021
    Copy the full SHA
    f05fe25 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Nitesh Kant <nitesh_kant@apple.com>
    @normanmaurer
    normanmaurer and Nitesh Kant committed Sep 8, 2021
    Copy the full SHA
    e0c11d6 View commit details
    Browse the repository at this point in the history

  2. Address comments

    @normanmaurer
    normanmaurer committed Sep 8, 2021
    Copy the full SHA
    85f15f8 View commit details
    Browse the repository at this point in the history

  3. Cleanup

    @normanmaurer
    normanmaurer committed Sep 8, 2021
    Copy the full SHA
    4960a92 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. address comment

    @normanmaurer
    normanmaurer committed Sep 9, 2021
    Copy the full SHA
    7e7f21a View commit details
    Browse the repository at this point in the history

  2. Don't use snapshot

    @normanmaurer
    normanmaurer committed Sep 9, 2021
    Copy the full SHA
    e805c40 View commit details
    Browse the repository at this point in the history