Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test failure reporting of EpollSocketChannelConfigTest #11570

Merged
merged 1 commit into from Aug 12, 2021

Commits on Aug 11, 2021

  1. Improve test failure reporting of EpollSocketChannelConfigTest

    Motivation:
    This test is inherently flaky due to file descriptor reuse.
    Even though we have taken steps to make it less flaky, it still fails sometimes.
    When it does, the error message is not very helpful.
    
    Modification:
    Make use of assertThrows and assertThat to get more descriptive error messages when the tests fail.
    
    Result:
    More meaningful messages on test failures, which may help us make the tests more resilient in the future
    chrisvest committed Aug 11, 2021
    Copy the full SHA
    e0bc84c View commit details
    Browse the repository at this point in the history