Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to pass through a certain HTTP upgrade request #11267

Merged
merged 3 commits into from May 18, 2021
Merged

Provide a way to pass through a certain HTTP upgrade request #11267

merged 3 commits into from May 18, 2021

Commits on May 18, 2021

  1. Provide a way to pass through a certain upgrade request 

    Motivation:

A user might want to handle a certain HTTP upgrade request differently
than what `HttpServerUpgradeHandler` does by default. For example, a
user could let `HttpServerUpgradeHandler` handle HTTP/2 upgrades but
not WebSocket upgrades.

Modifications:

- Added `HttpServerUpgradeHandler.isUpgrade(HttpRequest)` so a user can
  tell `HttpServerUpgradeHandler` to pass the request as it is to the
  next handler.

Result:

- A user can handle a certain upgrade request specially.
    @trustin
    trustin committed May 18, 2021
    Copy the full SHA
    f8705b4 View commit details
    Browse the repository at this point in the history

  2. Address the comment from @normanmaurer

    @trustin
    trustin committed May 18, 2021
    Copy the full SHA
    8c08fd2 View commit details
    Browse the repository at this point in the history

  3. Update Javadoc

    @trustin
    trustin committed May 18, 2021
    Copy the full SHA
    c5c3c58 View commit details
    Browse the repository at this point in the history