New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we can load the native library or fail the build #11262
Conversation
/cc @violetagg also related to your PR... This will ensure we not get into trouble again later on. |
Motivation: We used assumeTrue(...) in some places before to detect if we could load the native library but this could lead to the sitation that we not notice if we break native loading. Modifications: Always fail if we cant load the native library Result: Ensure we not cause any regression in the native loading code in the future
@normanmaurer Maybe not related, maybe only due to "latency" of Maven repositories, but when I update just few minutes ago to the last version of Netty (4.1.64), in my dependencies, I've got the netty native library (2.0.39), I've got an issue on cannot find depdencies such as the following. Could not resolve dependencies for...: The following artifacts could not be resolved:
I'm on Linux x64 (Ubundu based). |
@normanmaurer I will retry tomorrow, but just for note:
|
@fredericBregier can you show me your pom.xml file ? |
Motivation: We used assumeTrue(...) in some places before to detect if we could load the native library but this could lead to the sitation that we not notice if we break native loading. Modifications: Always fail if we cant load the native library Result: Ensure we not cause any regression in the native loading code in the future
@normanmaurer I opened an issue with a simple pom.xml with only Netty dependencies (no code, just a pom.xml) #11272 |
Motivation: We used assumeTrue(...) in some places before to detect if we could load the native library but this could lead to the sitation that we not notice if we break native loading. Modifications: Always fail if we cant load the native library Result: Ensure we not cause any regression in the native loading code in the future
Motivation:
We used assumeTrue(...) in some places before to detect if we could load the native library but this could lead to the sitation that we not notice if we break native loading.
Modifications:
Always fail if we cant load the native library
Result:
Ensure we not cause any regression in the native loading code in the future