Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly calculate the produced bytes in all cases when calling Refe… #10063

Merged
merged 4 commits into from
Feb 27, 2020
Merged

Correctly calculate the produced bytes in all cases when calling Refe… #10063

merged 4 commits into from
Feb 27, 2020

Commits on Feb 26, 2020

  1. Correctly calculate the produced bytes in all cases when calling Refe… 

    …renceCountedOpenSslEngine.wrap(...)

Motivation:

We did not correctly account for produced bytes when SSL_write(...) returns -1 in all cases. This could lead to lost data and so a corrupt SSL connection.

Modifications:

Always ensure we calculate the produced bytes correctly

Result:

Fixes #10041
    @normanmaurer
    normanmaurer committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    628fda1 View commit details
    Browse the repository at this point in the history

  2. Add unit test

    @normanmaurer
    normanmaurer committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    b59cc29 View commit details
    Browse the repository at this point in the history

  3. Add unit tests

    @normanmaurer
    normanmaurer committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    63c2f7c View commit details
    Browse the repository at this point in the history

  4. Scotts comment

    @normanmaurer
    normanmaurer committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    f4e91db View commit details
    Browse the repository at this point in the history