Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Checkstyle to 8.18+ #8968

Closed
trustin opened this issue Mar 22, 2019 · 2 comments
Closed

Update Checkstyle to 8.18+ #8968

trustin opened this issue Mar 22, 2019 · 2 comments
Assignees
@normanmaurer
Labels
cleanup
Milestone
4.1.35.Final

Comments

@trustin
Copy link
Member

trustin commented Mar 22, 2019

.. because of potential vulnerability during the build. See: https://nvd.nist.gov/vuln/detail/CVE-2019-9658 and checkstyle/checkstyle#6474
@normanmaurer
Copy link
Member

working on it

@trustin
Copy link
Member Author

trustin commented Mar 26, 2019

Thanks, @normanmaurer

@normanmaurer normanmaurer self-assigned this Mar 26, 2019
@normanmaurer normanmaurer mentioned this issue Mar 26, 2019
Merged
normanmaurer added a commit that referenced this issue Mar 26, 2019
@normanmaurer
Upgrade to new netty-build and com.puppycrawl.tools 8.18
09cd015 
Motivation:

com.puppycrawl.tools checkstyle < 8.18 was reported to contain a possible security flaw. We should upgrade.

Modifications:

- Upgrade netty-build and checkstyle.
- Fix checkstyle errors

Result:

Fixes #8968.
normanmaurer added a commit that referenced this issue Mar 26, 2019
@normanmaurer
Upgrade to new netty-build and com.puppycrawl.tools 8.18 (#8980)
8206604 
Motivation:

com.puppycrawl.tools checkstyle < 8.18 was reported to contain a possible security flaw. We should upgrade.

Modifications:

- Upgrade netty-build and checkstyle.
- Fix checkstyle errors

Result:

Fixes #8968.
@normanmaurer normanmaurer added this to the 4.1.35.Final milestone Mar 26, 2019
normanmaurer added a commit that referenced this issue Mar 26, 2019
@normanmaurer
Upgrade to new netty-build and com.puppycrawl.tools 8.18 (#8980)
6297f18 
Motivation:

com.puppycrawl.tools checkstyle < 8.18 was reported to contain a possible security flaw. We should upgrade.

Modifications:

- Upgrade netty-build and checkstyle.
- Fix checkstyle errors

Result:

Fixes #8968.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
cleanup
Projects
None yet
Milestone
4.1.35.Final
Development

No branches or pull requests
2 participants
@trustin @normanmaurer