Enable SocketHalfClosedTest for epoll #13025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: These tests were not being run for epoll because the classes did not have the Test suffix. We also aren't regularly running these tests for kqueue because we don't have a MacOS CI build. It turns out that all transports now behave consistently with regards to read-completes after input shutdown, so the tests don't need to change their assertions for epoll/kqueue vs. NIO. Modification: Enable the SocketHalfClosedTest for epoll, both edge and level triggered. Remove test parameter adjustments for epoll and kqueue. Result: SocketHalfClosedTest tests now run, and pass, for epoll.
Although, this really should not be part of the public API.
normanmaurer
requested changes
Nov 28, 2022
testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
These tests were not being run for epoll because the classes did not have the Test suffix. We also aren't regularly running these tests for kqueue because we don't have a MacOS CI build. It turns out that all transports now behave consistently with regards to read-completes after input shutdown, so the tests don't need to change their assertions for epoll/kqueue vs. NIO.
Modification:
Enable the SocketHalfClosedTest for epoll, both edge and level triggered. Remove test parameter adjustments for epoll and kqueue.
Result:
SocketHalfClosedTest tests now run, and pass, for epoll.
This is a back port of #12993