Correctly calculate the produced bytes in all cases when calling Refe… #10063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…renceCountedOpenSslEngine.wrap(...) Motivation: We did not correctly account for produced bytes when SSL_write(...) returns -1 in all cases. This could lead to lost data and so a corrupt SSL connection. Modifications: Always ensure we calculate the produced bytes correctly Result: Fixes #10041
|
I just posted this to give early access. Still working on a test case and so will wait with merging until I have one ready |
normanmaurer
force-pushed
the
ssl_wrap_bug
branch
from
c58d8c7
to
63c2f7c
Compare
|
test added... |
Scottmitch
approved these changes
Feb 26, 2020
handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java
Outdated
Show resolved
Hide resolved
ihanyong
pushed a commit
to ihanyong/netty
that referenced
this pull request
Jul 31, 2020
netty#10063) Motivation: We did not correctly account for produced bytes when SSL_write(...) returns -1 in all cases. This could lead to lost data and so a corrupt SSL connection. Modifications: - Always ensure we calculate the produced bytes correctly - Add unit tests Result: Fixes netty#10041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…renceCountedOpenSslEngine.wrap(...)
Motivation:
We did not correctly account for produced bytes when SSL_write(...) returns -1 in all cases. This could lead to lost data and so a corrupt SSL connection.
Modifications:
Always ensure we calculate the produced bytes correctly
Result:
Fixes #10041