Skip to content

Commit

Permalink
Exclude transitive dependencies of rarely used modules from netty-all (
Browse files Browse the repository at this point in the history
…#11786)

Motivation:
Netty-all is used to unconditionally pull in all netty modules with the same version.
Some of these modules have dependencies themselves that are pulled in transitively, yet they are rarely used.

Modification:
Exclude the transitive dependencies of netty-codec-xml, netty-transport-rxtx, and netty-transport-udt.

Those who wish to restore these modules to working order can additionally depend on org.fasterxml:aalto-xml, org.rxtx:rxtx, or com.barchart.udt:barchart-udt-bundle, respectively.

Result:
Depending on netty-all no longer transitively depends on any non-netty maven modules.
  • Loading branch information
chrisvest committed Oct 25, 2021
1 parent 77b7c1a commit e1d2a95
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions all/pom.xml
Expand Up @@ -250,6 +250,12 @@
<groupId>${project.groupId}</groupId>
<artifactId>netty-codec-xml</artifactId>
<scope>compile</scope>
<exclusions>
<exclusion>
<groupId>com.fasterxml</groupId>
<artifactId>aalto-xml</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
Expand Down Expand Up @@ -285,6 +291,12 @@
<groupId>${project.groupId}</groupId>
<artifactId>netty-transport-rxtx</artifactId>
<scope>compile</scope>
<exclusions>
<exclusion>
<groupId>org.rxtx</groupId>
<artifactId>rxtx</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
Expand All @@ -295,6 +307,12 @@
<groupId>${project.groupId}</groupId>
<artifactId>netty-transport-udt</artifactId>
<scope>compile</scope>
<exclusions>
<exclusion>
<groupId>com.barchart.udt</groupId>
<artifactId>barchart-udt-bundle</artifactId>
</exclusion>
</exclusions>
</dependency>
<!--
Use no classifier for the native dependencies. The dependencies with the classifier are added by the
Expand Down

0 comments on commit e1d2a95

Please sign in to comment.