Skip to content

Commit

Permalink
Fail build if netty-all pulls in duplicated classes (#11804)
Browse files Browse the repository at this point in the history
Motivation:

We should fail the build if netty-all pulls in dependencies that produce duplicated classes on the classpath

Modifications:

Add maven plugin to verify we not have duplicated classes on the classpath / dependencies

Result:

Related to #11791
  • Loading branch information
normanmaurer committed Oct 28, 2021
1 parent 555fcf2 commit baba1f4
Showing 1 changed file with 25 additions and 0 deletions.
25 changes: 25 additions & 0 deletions all/pom.xml
Expand Up @@ -181,6 +181,31 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.basepom.maven</groupId>
<artifactId>duplicate-finder-maven-plugin</artifactId>
<version>1.3.0</version>
<executions>
<execution>
<id>default</id>
<phase>validate</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration>
<failBuildInCaseOfDifferentContentConflict>true</failBuildInCaseOfDifferentContentConflict>
<failBuildInCaseOfEqualContentConflict>true</failBuildInCaseOfEqualContentConflict>
<failBuildInCaseOfConflict>true</failBuildInCaseOfConflict>
<checkCompileClasspath>true</checkCompileClasspath>
<checkRuntimeClasspath>true</checkRuntimeClasspath>
<checkTestClasspath>false</checkTestClasspath>
<preferLocal>true</preferLocal>
<useResultFile>true</useResultFile>
<resultFile>${project.build.directory}/duplicate-finder-result.xml</resultFile>
</configuration>
</plugin>
</plugins>
</build>

Expand Down

0 comments on commit baba1f4

Please sign in to comment.