Remove usage of japicmp-maven-plugin (#14015)

Motivation:

Let's remove the usage of japicmp-maven-plugin and just use revapi.

Modifications:

Remove usage of japicmp-maven-plugin

Result:

Cleanup

all/pom.xml

@@ -32,7 +32,6 @@
     <javaModuleName>io.netty.all</javaModuleName>
     <generatedSourceDir>${project.build.directory}/src</generatedSourceDir>
     <dependencyVersionsDir>${project.build.directory}/versions</dependencyVersionsDir>
-    <japicmp.skip>true</japicmp.skip>
   </properties>
 
   <dependencyManagement>

example/pom.xml

@@ -30,7 +30,6 @@
   <name>Netty/Example</name>
 
   <properties>
-    <japicmp.skip>true</japicmp.skip>
     <javaModuleName>io.netty.example</javaModuleName>
   </properties>
   <dependencies>

microbench/pom.xml

@@ -38,7 +38,6 @@
     <!-- This only be set when run on mac as on other platforms we just want to include the jar without native
          code -->
     <kqueue.classifier />
-    <japicmp.skip>true</japicmp.skip>
     <revapi.skip>true</revapi.skip>
     <javaModuleName>io.netty.microbench</javaModuleName>
   </properties>

pom.xml

@@ -560,7 +560,6 @@
       <properties>
         <forbiddenapis.skip>true</forbiddenapis.skip>
         <checkstyle.skip>true</checkstyle.skip>
-        <japicmp.skip>true</japicmp.skip>
         <revapi.skip>true</revapi.skip>
         <xml.skip>true</xml.skip>
         <skipShadingTestsuite>true</skipShadingTestsuite>
@@ -1853,88 +1852,6 @@
           </execution>
         </executions>
       </plugin>
-      <plugin>
-        <groupId>com.github.siom79.japicmp</groupId>
-        <artifactId>japicmp-maven-plugin</artifactId>
-        <version>0.21.0</version>
-        <configuration>
-          <parameter>
-            <ignoreMissingOldVersion>true</ignoreMissingOldVersion>
-            <breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
-            <breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
-            <oldVersionPattern>\d+\.\d+\.\d+\.Final</oldVersionPattern>
-            <ignoreMissingClassesByRegularExpressions>
-              <!-- ignore everything which is not part of netty itself as the plugin can not handle optional dependencies -->
-              <ignoreMissingClassesByRegularExpression>^(?!io\.netty\.).*</ignoreMissingClassesByRegularExpression>
-              <ignoreMissingClassesByRegularExpression>^io\.netty\.internal\.tcnative\..*</ignoreMissingClassesByRegularExpression>
-            </ignoreMissingClassesByRegularExpressions>
-            <excludes>
-              <exclude>@io.netty.util.internal.UnstableApi</exclude>
-              <exclude>io.netty.util.internal.shaded</exclude>
-            </excludes>
-            <overrideCompatibilityChangeParameters>
-              <overrideCompatibilityChangeParameter>
-                <compatibilityChange>FIELD_REMOVED</compatibilityChange>
-                <sourceCompatible>true</sourceCompatible>
-                <binaryCompatible>true</binaryCompatible>
-                <semanticVersionLevel>PATCH</semanticVersionLevel>
-              </overrideCompatibilityChangeParameter>
-              <!-- Changes for IoHandle concept -->
-              <overrideCompatibilityChangeParameter>
-                <compatibilityChange>INTERFACE_ADDED</compatibilityChange>
-                <sourceCompatible>true</sourceCompatible>
-                <binaryCompatible>true</binaryCompatible>
-                <semanticVersionLevel>PATCH</semanticVersionLevel>
-              </overrideCompatibilityChangeParameter>
-              <overrideCompatibilityChangeParameter>
-                <compatibilityChange>METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE</compatibilityChange>
-                <sourceCompatible>true</sourceCompatible>
-                <binaryCompatible>true</binaryCompatible>
-                <semanticVersionLevel>PATCH</semanticVersionLevel>
-              </overrideCompatibilityChangeParameter>
-              <overrideCompatibilityChangeParameter>
-                <compatibilityChange>METHOD_DEFAULT_ADDED_IN_IMPLEMENTED_INTERFACE</compatibilityChange>
-                <sourceCompatible>true</sourceCompatible>
-                <binaryCompatible>true</binaryCompatible>
-                <semanticVersionLevel>PATCH</semanticVersionLevel>
-              </overrideCompatibilityChangeParameter>
-              <!-- Can we somehow only override this per class ?-->
-              <overrideCompatibilityChangeParameter>
-                <compatibilityChange>SUPERCLASS_REMOVED</compatibilityChange>
-                <sourceCompatible>true</sourceCompatible>
-                <binaryCompatible>true</binaryCompatible>
-                <semanticVersionLevel>PATCH</semanticVersionLevel>
-              </overrideCompatibilityChangeParameter>
-              <overrideCompatibilityChangeParameter>
-                <compatibilityChange>METHOD_REMOVED</compatibilityChange>
-                <sourceCompatible>true</sourceCompatible>
-                <binaryCompatible>true</binaryCompatible>
-                <semanticVersionLevel>PATCH</semanticVersionLevel>
-              </overrideCompatibilityChangeParameter>
-              <overrideCompatibilityChangeParameter>
-                <compatibilityChange>METHOD_NOW_FINAL</compatibilityChange>
-                <sourceCompatible>true</sourceCompatible>
-                <binaryCompatible>true</binaryCompatible>
-                <semanticVersionLevel>PATCH</semanticVersionLevel>
-              </overrideCompatibilityChangeParameter>
-              <overrideCompatibilityChangeParameter>
-                <compatibilityChange>METHOD_ADDED_TO_INTERFACE</compatibilityChange>
-                <sourceCompatible>true</sourceCompatible>
-                <binaryCompatible>true</binaryCompatible>
-                <semanticVersionLevel>PATCH</semanticVersionLevel>
-              </overrideCompatibilityChangeParameter>
-            </overrideCompatibilityChangeParameters>
-          </parameter>
-        </configuration>
-        <executions>
-          <execution>
-            <phase>verify</phase>
-            <goals>
-              <goal>cmp</goal>
-            </goals>
-          </execution>
-        </executions>
-      </plugin>
       <plugin>
         <artifactId>maven-enforcer-plugin</artifactId>
         <version>${enforcer.plugin.version}</version>

resolver-dns-native-macos/pom.xml

@@ -366,7 +366,6 @@
     <unix.common.include.unpacked.dir>${unix.common.lib.dir}/META-INF/native/include</unix.common.include.unpacked.dir>
     <jni.compiler.args.cflags>CFLAGS=-O3 -Werror -fno-omit-frame-pointer -Wunused-variable -fvisibility=hidden -I${unix.common.include.unpacked.dir}</jni.compiler.args.cflags>
     <jni.compiler.args.ldflags>LDFLAGS=-z now -L${unix.common.lib.unpacked.dir} -Wl,--whole-archive -l${unix.common.lib.name} -Wl,--no-whole-archive</jni.compiler.args.ldflags>
-    <japicmp.skip>true</japicmp.skip>
     <!-- Always check JNI during test run so we catch bugs that could cause crashes -->
     <argLine.jni>-Xcheck:jni</argLine.jni>
   </properties>

testsuite-autobahn/pom.xml

@@ -29,7 +29,6 @@
   <name>Netty/Testsuite/Autobahn</name>
 
   <properties>
-    <japicmp.skip>true</japicmp.skip>
     <revapi.skip>true</revapi.skip>
     <!-- Do not deploy this module -->
     <skipDeploy>true</skipDeploy>

testsuite-http2/pom.xml

@@ -29,7 +29,6 @@
   <name>Netty/Testsuite/Http2</name>
 
   <properties>
-    <japicmp.skip>true</japicmp.skip>
     <revapi.skip>true</revapi.skip>
     <!-- Do not deploy this module -->
     <skipDeploy>true</skipDeploy>

testsuite-native-image-client-runtime-init/pom.xml

@@ -29,7 +29,6 @@
   <name>Netty/Testsuite/NativeImage/ClientRuntimeInit</name>
 
   <properties>
-    <japicmp.skip>true</japicmp.skip>
     <revapi.skip>true</revapi.skip>
     <!-- Do not deploy this module -->
     <skipDeploy>true</skipDeploy>

testsuite-native-image-client/pom.xml

@@ -29,7 +29,6 @@
   <name>Netty/Testsuite/NativeImage/Client</name>
 
   <properties>
-    <japicmp.skip>true</japicmp.skip>
     <revapi.skip>true</revapi.skip>
     <!-- Do not deploy this module -->
     <skipDeploy>true</skipDeploy>

testsuite-native-image/pom.xml

@@ -29,7 +29,6 @@
   <name>Netty/Testsuite/NativeImage</name>
 
   <properties>
-    <japicmp.skip>true</japicmp.skip>
     <revapi.skip>true</revapi.skip>
     <!-- Do not deploy this module -->
     <skipDeploy>true</skipDeploy>

testsuite-native/pom.xml

@@ -29,7 +29,6 @@
   <name>Netty/Testsuite/Native</name>
 
   <properties>
-    <japicmp.skip>true</japicmp.skip>
     <revapi.skip>true</revapi.skip>
     <skipNativeTestsuite>false</skipNativeTestsuite>
     <!-- Do not deploy this module -->

testsuite-osgi/pom.xml

@@ -31,8 +31,6 @@
   <properties>
     <exam.version>4.13.0</exam.version>
     <argLine.java9.extras>--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.security=ALL-UNNAMED</argLine.java9.extras>
-    <japicmp.skip>true</japicmp.skip>
-    <revapi.skip>true</revapi.skip>
     <!-- Do not deploy this module -->
     <skipDeploy>true</skipDeploy>
     <javaModuleName>io.netty.testsuite_osgi</javaModuleName>

testsuite-shading/pom.xml

@@ -39,7 +39,6 @@
     <mangledShadingPrefix2>shaded_12</mangledShadingPrefix2>
     <skipShadingTestsuite>true</skipShadingTestsuite>
     <shadedPackagePrefix>io.netty.</shadedPackagePrefix>
-    <japicmp.skip>true</japicmp.skip>
     <revapi.skip>true</revapi.skip>
     <!-- Do not deploy this module -->
     <skipDeploy>true</skipDeploy>

testsuite/pom.xml

@@ -126,7 +126,6 @@
   <properties>
     <!-- Needed for SSL tests as these use the SelfSignedCertificate --> 
     <argLine.java9.extras>--add-exports java.base/sun.security.x509=ALL-UNNAMED</argLine.java9.extras>
-    <japicmp.skip>true</japicmp.skip>
     <revapi.skip>true</revapi.skip>
     <javaModuleName>io.netty.testsuite</javaModuleName>
   </properties>

transport-blockhound-tests/pom.xml

@@ -120,7 +120,6 @@
     <maven.compiler.target>1.8</maven.compiler.target>
     <!-- Needed for SelfSignedCertificate -->
     <argLine.java9.extras>--add-exports java.base/sun.security.x509=ALL-UNNAMED</argLine.java9.extras>
-    <japicmp.skip>true</japicmp.skip>
     <!-- Do not deploy this module -->
     <skipDeploy>true</skipDeploy>
     <javaModuleName>io.netty.transport_blockhound_tests</javaModuleName>

transport-native-epoll/pom.xml

@@ -42,7 +42,6 @@
     <jni.compiler.args.libs>LIBS=-Wl,--whole-archive -l${unix.common.lib.name} -Wl,--no-whole-archive -ldl</jni.compiler.args.libs>
     <nativeSourceDirectory>${project.basedir}/src/main/c</nativeSourceDirectory>
     <skipTests>true</skipTests>
-    <japicmp.skip>true</japicmp.skip>
   </properties>
 
   <profiles>

transport-native-kqueue/pom.xml

@@ -604,7 +604,6 @@
     <jni.compiler.args.cflags>CFLAGS=-O3 -Werror -fno-omit-frame-pointer -Wunused-variable -fvisibility=hidden -I${unix.common.include.unpacked.dir}</jni.compiler.args.cflags>
     <jni.compiler.args.ldflags>LDFLAGS=-z now -L${unix.common.lib.unpacked.dir} -Wl,--whole-archive -l${unix.common.lib.name} -Wl,--no-whole-archive</jni.compiler.args.ldflags>
     <nativeSourceDirectory>${project.basedir}/src/main/c</nativeSourceDirectory>
-    <japicmp.skip>true</japicmp.skip>
   </properties>
 
   <dependencies>