Skip to content

Commit

Permalink
Remove usage of japicmp-maven-plugin (#14015)
Browse files Browse the repository at this point in the history
Motivation:

Let's remove the usage of japicmp-maven-plugin and just use revapi.

Modifications:

Remove usage of japicmp-maven-plugin

Result:

Cleanup
  • Loading branch information
normanmaurer committed Apr 30, 2024
1 parent acd6c18 commit 6be07ca
Show file tree
Hide file tree
Showing 12 changed files with 0 additions and 42 deletions.
1 change: 0 additions & 1 deletion all/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
<javaModuleName>io.netty5.all</javaModuleName>
<generatedSourceDir>${project.build.directory}/src</generatedSourceDir>
<dependencyVersionsDir>${project.build.directory}/versions</dependencyVersionsDir>
<japicmp.skip>true</japicmp.skip>
</properties>

<dependencyManagement>
Expand Down
1 change: 0 additions & 1 deletion example/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
<name>Netty5/Example</name>

<properties>
<japicmp.skip>true</japicmp.skip>
<javaModuleName>io.netty5.example</javaModuleName>
</properties>

Expand Down
1 change: 0 additions & 1 deletion microbench/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
<!-- This only be set when run on mac as on other platforms we just want to include the jar without native
code -->
<kqueue.classifier />
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<javaModuleName>io.netty5.microbench</javaModuleName>
</properties>
Expand Down
31 changes: 0 additions & 31 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,6 @@
<properties>
<forbiddenapis.skip>true</forbiddenapis.skip>
<checkstyle.skip>true</checkstyle.skip>
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<xml.skip>true</xml.skip>
<skipShadingTestsuite>true</skipShadingTestsuite>
Expand Down Expand Up @@ -1038,36 +1037,6 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
<version>0.21.0</version>
<configuration>
<parameter>
<ignoreMissingOldVersion>true</ignoreMissingOldVersion>
<breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
<breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
<oldVersionPattern>\d+\.\d+\.\d+\.Final</oldVersionPattern>
<ignoreMissingClassesByRegularExpressions>
<!-- ignore everything which is not part of netty itself as the plugin can not handle optional dependencies -->
<ignoreMissingClassesByRegularExpression>^(?!io\.netty5\.).*</ignoreMissingClassesByRegularExpression>
<ignoreMissingClassesByRegularExpression>^io\.netty\.internal\.tcnative\..*</ignoreMissingClassesByRegularExpression>
</ignoreMissingClassesByRegularExpressions>
<excludes>
<exclude>@io.netty5.util.internal.UnstableApi</exclude>
<exclude>io.netty5.util.internal.shaded</exclude>
</excludes>
</parameter>
</configuration>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>cmp</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-enforcer-plugin</artifactId>
<version>${enforcer.plugin.version}</version>
Expand Down
1 change: 0 additions & 1 deletion testsuite-autobahn/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
<name>Netty5/Testsuite/Autobahn</name>

<properties>
<japicmp.skip>true</japicmp.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty5.testsuite_autobahn</javaModuleName>
Expand Down
1 change: 0 additions & 1 deletion testsuite-http2/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
<name>Netty5/Testsuite/Http2</name>

<properties>
<japicmp.skip>true</japicmp.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty5.testsuite_http2</javaModuleName>
Expand Down
1 change: 0 additions & 1 deletion testsuite-native-image-client-runtime-init/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
<name>Netty5/Testsuite/NativeImage/ClientRuntimeInit</name>

<properties>
<japicmp.skip>true</japicmp.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty5.testsuite_native_image_client_runtime_init</javaModuleName>
Expand Down
1 change: 0 additions & 1 deletion testsuite-native-image-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
<name>Netty5/Testsuite/NativeImage/Client</name>

<properties>
<japicmp.skip>true</japicmp.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty5.testsuite_native_image_client</javaModuleName>
Expand Down
1 change: 0 additions & 1 deletion testsuite-native-image/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
<name>Netty5/Testsuite/NativeImage</name>

<properties>
<japicmp.skip>true</japicmp.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty5.testsuite_native_image</javaModuleName>
Expand Down
1 change: 0 additions & 1 deletion testsuite-native/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
<name>Netty5/Testsuite/Native</name>

<properties>
<japicmp.skip>true</japicmp.skip>
<skipNativeTestsuite>false</skipNativeTestsuite>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
Expand Down
1 change: 0 additions & 1 deletion testsuite-osgi/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
<properties>
<exam.version>4.13.0</exam.version>
<argLine.java9.extras>--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.security=ALL-UNNAMED</argLine.java9.extras>
<japicmp.skip>true</japicmp.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty5.testsuite_osgi</javaModuleName>
Expand Down
1 change: 0 additions & 1 deletion testsuite-shading/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
<mangledShadingPrefix2>shaded_12</mangledShadingPrefix2>
<skipShadingTestsuite>true</skipShadingTestsuite>
<shadedPackagePrefix>io.netty5.</shadedPackagePrefix>
<japicmp.skip>true</japicmp.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty5.testsuite_shading</javaModuleName>
Expand Down

0 comments on commit 6be07ca

Please sign in to comment.