-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrays::updateDiff() #246
Open
milo
wants to merge
2
commits into
nette:master
Choose a base branch
from
milo:pull-array-diff
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Arrays::updateDiff() #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it's like |
Yes. Behaviour probably same as: return array_udiff_assoc($to, $from, function ($a, $b) {
return $a === $b ? 0 : ($a > $b ? 1 : -1); # spaceship cannot be used because null <=> false === 0
}); I write probably, because I'm not sure why yes/no comparator can return -1/0/1 and how result depends on it. |
dg
force-pushed
the
master
branch
4 times, most recently
from
January 11, 2021 03:06
740520b
to
2bc2f58
Compare
dg
force-pushed
the
master
branch
11 times, most recently
from
March 4, 2021 20:13
eb3a987
to
adead06
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
April 22, 2021 16:23
c5fe864
to
f06376c
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
August 16, 2021 21:07
1d3a574
to
f857e45
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
August 24, 2021 11:32
2aa5187
to
9f1c637
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
September 27, 2023 09:53
38d3044
to
a3ce3eb
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
October 17, 2023 08:26
38cc5db
to
0a8a17e
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
November 1, 2023 20:33
4b7b01e
to
494d200
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
November 26, 2023 23:02
b843c77
to
77e9645
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
December 5, 2023 14:51
7ae8df7
to
0d1508c
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
January 17, 2024 16:51
5b5c893
to
81e3e6d
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
May 3, 2024 11:20
b080db7
to
d668e02
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
May 16, 2024 20:06
1e73622
to
d6a9961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed
Arrays::updateDiff()
compares two associative arrays and returns such items from later one, which does not exist or differs from first one. By other words - which items have to be updated in first array, to be the same as second array.As far as I know, there is no PHP function for that (playground). For examle:
There are posible things to debate:
callable $comparator = null