Strings::indexOf() fixed empty $haystack and negative $nth [Closes #271]

nette · Nov 22, 2021 · 075301b · 075301b
1 parent 2ca60ae
commit 075301b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/Utils/Strings.php b/src/Utils/Strings.php
@@ -456,6 +456,8 @@ private static function pos(string $haystack, string $needle, int $nth = 1): ?in
 			$len = strlen($haystack);
 			if ($needle === '') {
 				return $len;
+			} elseif ($len === 0) {
+				return null;
 			}
 			$pos = $len - 1;
 			while (($pos = strrpos($haystack, $needle, $pos - $len)) !== false && ++$nth) {

diff --git a/tests/Utils/Strings.indexOf().phpt b/tests/Utils/Strings.indexOf().phpt
@@ -31,6 +31,8 @@ test('', function () {
 	Assert::null(Strings::indexOf($foo, 'not-in-string'));
 	Assert::null(Strings::indexOf($foo, 'b', -2));
 	Assert::null(Strings::indexOf($foo, 'b', 2));
+	Assert::null(Strings::indexOf('', 'a', 1));
+	Assert::null(Strings::indexOf('', 'a', -1));
 });