Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @netlify/eslint-config-node to ^3.0.3 #490

Merged
merged 3 commits into from May 30, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 30, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@netlify/eslint-config-node ^3.0.1 -> ^3.0.3 age adoption passing confidence

Release Notes

netlify/eslint-config-node

v3.0.3

Compare Source

v3.0.2

Compare Source


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label May 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2021

⏱ Benchmark results

Comparing with 73bf246

largeDepsEsbuild: 12.8s

⬆️ 8.30% increase vs. 73bf246

^          13.3s                                  
│           ┌──┐                           12.8s  
│  11.7s    |  |   11.9s                    ┌──┐  
│   ┌──┐    |  |    ┌──┐           11.5s    |▒▒|  
│   |  |    |  |    |  |            ┌──┐    |▒▒|  
│   |  |    |  |    |  |   10.2s    |  |    |▒▒|  
│   |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsZisi: 1m 8.6s

⬆️ 4.23% increase vs. 73bf246

^         1m 12.2s                                
│           ┌──┐                          1m 8.6s 
│ 1m 5.7s   |  |  1m 5.7s         1m 3.7s   ┌──┐  
│   ┌──┐    |  |    ┌──┐            ┌──┐    |▒▒|  
│   |  |    |  |    |  |            |  |    |▒▒|  
│   |  |    |  |    |  |   54.5s    |  |    |▒▒|  
│   |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-5     T-4     T-3     T-2     T-1      T    
Legend

Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I had to do a full uninstall and install of @netlify/eslint-config-node to get the correct version of eslint-config-standard that supports both eslint-plugin-promise@4 and eslint-plugin-promise@5 when installed using npm@6

@erezrokah erezrokah force-pushed the renovate/netlify-eslint-config-node-3.x branch from 0d30908 to 23c65b1 Compare May 30, 2021 14:25
@erezrokah
Copy link
Contributor

For some reason I had to do a full uninstall and install of @netlify/eslint-config-node to get the correct version of eslint-config-standard that supports both eslint-plugin-promise@4 and eslint-plugin-promise@5 when installed using npm@6

Apparently this fixed the tests on Node.js 10 but causing them to fail on 16 only in CI - they are working locally for me

@erezrokah erezrokah force-pushed the renovate/netlify-eslint-config-node-3.x branch from 23c65b1 to 7ce06ba Compare May 30, 2021 18:59
@@ -1,2 +1 @@
// eslint-disable-next-line import/no-extraneous-dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erezrokah erezrokah merged commit 57e57ab into main May 30, 2021
@erezrokah erezrokah deleted the renovate/netlify-eslint-config-node-3.x branch May 30, 2021 19:04
@erezrokah
Copy link
Contributor

Apparently this fixed the tests on Node.js 10 but causing them to fail on 16 only in CI - they are working locally for me

Re-generating the lock file seems to have fixed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants