Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to rubocop < 2 #9

Merged
merged 3 commits into from Mar 27, 2021
Merged

Update dependencies to rubocop < 2 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
068f976
Update to rubocop 0.90
kitop Mar 27, 2021
93a6f35
Update to < 1.0
kitop Mar 27, 2021
39dc3cc
Update to < 2.0
kitop Mar 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/rubocop/cop/netlify/invalid_model_assignment.rb
View file
Open in desktop
Expand Up @@ -13,7 +13,6 @@ module Netlify
# form.email = "bettse@netlify.com"
class InvalidModelAssignment < Cop
MSG = "Assigning to `attributes` will not update record"
RESTRICT_ON_SEND = [:attributes].freeze

def_node_matcher :assign_attributes?, <<~PATTERN
(send (send (...) :attributes) :[]= _ _)
Expand Down
2 changes: 1 addition & 1 deletion rubocop-netlify.gemspec
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
spec.license = "MIT"
spec.required_ruby_version = Gem::Requirement.new(">= 2.5.0")

spec.add_dependency "rubocop", "~> 0.72", "< 0.90"
spec.add_dependency "rubocop", "~> 0.72", "< 2.0"
spec.add_development_dependency "minitest", "~> 5.10"

# Specify which files should be added to the gem when it is released.
Expand Down