Update rubocop dependency to < 2.0 #8
Conversation
kitop
added
the
type: chore
Remove RESTRICT_ON_SEND on InvalidModelAssignment cop since it wasn't doing what we thought it did. Unitl < 0.90 it was ignored so we didn't notice.
Update dependencies to rubocop < 2
kitop
changed the title
| needed = Hash.new { |h, k| h[k] = [] } | ||
| Array(cop.class.joining_forces).each { |force| needed[force] << cop } | ||
| forces = needed.map do |force_class, joining_cops| | ||
| force_class.new(joining_cops) |
There was a problem hiding this comment.
can you comment more on why you needed to make this change?
There was a problem hiding this comment.
Oh yes, sorry! I thought it was in a commit comment but I missed it.
Change was introduced in rubocop/rubocop@f8813e7 on v0.87. Details are vague, because it's a big commit/PR, but it removes the join_force? method in favor of joining_forces)
In reality, I just copy-pasted the updated version from https://github.com/rubocop/rubocop-minitest/blob/v0.11.0/test/assertion_helper.rb (As noted in the top of this file, the entire file is copied from there)
| next unless cop.join_force?(klass) | ||
|
|
||
| instances << klass.new([cop]) | ||
| needed = Hash.new { |h, k| h[k] = [] } |
There was a problem hiding this comment.
I'm... not sure why this is needed to be defined like this (v.s. needed = Hash.new) 🤔
There was a problem hiding this comment.
Good question! It's another Ruby nicety
This creates a hash where the default value is a new hash (new as in new every time, not the same array as it'd happen with Hash.new([]))
This allows to use << in the line below without having to initialize each needed[x] every time.
More details:
First part of updating the required version of rubocop to unblock upgrades in applications that use this gem. This goes up to 0.89 before having to get into bigger changes.
I required some changes in custom assertions code when going to 0.87 so now tests will have to be run with latest version. It doesn't affect the cops, so it's safe to bump.
More updates to come in separate PRs.Update: Merged #9. Now it supports up to < 2.0
One thing changed when updating to 0.90, we were using
RESTRICT_ON_SENDin an unintended way and before 0.90 it was ignored. See rubocop/rubocop#8365