Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update mongo driver #228

Merged
merged 2 commits into from Apr 1, 2021
Merged

fix: update mongo driver #228

merged 2 commits into from Apr 1, 2021

Conversation

kschlarman
Copy link
Contributor

Changes to downstream package names appear to be breaking builds. See mongodb/mongo-go-driver#624

BREAKING CHANGES: updates mongo driver from v1.4.1 to v1.5.1

@kschlarman kschlarman added the type: chore work needed to keep the product and development running smoothly label Mar 30, 2021
@kschlarman kschlarman requested a review from a team as a code owner March 30, 2021 22:06
@kschlarman
Copy link
Contributor Author

This resolves the dependency error I am seeing, if we are ok with bumping the driver.

#15 117.0 go: github.com/netlify/netlify-commons@v0.51.3 requires
#15 117.0       go.mongodb.org/mongo-driver@v1.4.1 requires
#15 117.0       github.com/xdg/stringprep@v0.0.0-20180714160509-73f8eece6fdc: invalid version: unknown revision 73f8eece6fdc

mheffner
mheffner approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@mheffner mheffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@kschlarman kschlarman merged commit e703089 into master Apr 1, 2021
@kschlarman kschlarman deleted the update-mong-driver branch April 1, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheffner mheffner mheffner approved these changes

Assignees
No one assigned
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kschlarman @mheffner