Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

chore: changed qwik default port to 5173 #801

Merged
merged 3 commits into from
Sep 23, 2022

Conversation

nickytonline
Copy link
Contributor

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

npm init qwik@latest sets a new qwik app's local development port to 5173 to line up with changes to vite's recent port change. Given the project is fairly new, this should have minimal impact, if any to folks using Qwik on Netlify. This was originally part if #792, but since we're still discussing the change to the vite default port, I opted to put this in its own PR.

And if for some reason they are using the old port currently, a message will notify them that they can change the target port in the netlify.toml

Relates to #791

A cat with it's mouth wide open


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This
    ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
    typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Aug 1, 2022
sarahetter
sarahetter previously approved these changes Aug 1, 2022
Copy link

@sarahetter sarahetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰

@nickytonline
Copy link
Contributor Author

I'm going to put this back to draft for the moment, because I'm not sure if this framework is meant to only be used with our Edge starter, https://github.com/BuilderIO/qwik/tree/main/starters/servers/netlify

@nickytonline nickytonline marked this pull request as draft August 1, 2022 19:56
ericapisani
ericapisani previously approved these changes Aug 2, 2022
@nickytonline nickytonline marked this pull request as ready for review August 3, 2022 21:54
@nickytonline nickytonline force-pushed the nickytonline/chore-change-qwik-default-port branch from 89423ac to 52b7088 Compare August 4, 2022 03:23
@nickytonline nickytonline merged commit f6a8cde into main Sep 23, 2022
@nickytonline nickytonline deleted the nickytonline/chore-change-qwik-default-port branch September 23, 2022 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants