fix: override conflicting semicolon rule #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orinokai
changed the title
orinokai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a conflict between
@typescript-eslint/no-extra-semi(which is part of the@typescript-eslint/recommendedconfig) and the prettier rulesemi: false.The prettier rule will add a semicolon in the following instance to protect from ASI failures.
https://github.com/netlify/next-runtime/blob/main/packages/runtime/src/helpers/config.ts#L95
However, the linter then complains because of the
no-extra-semirule.Since we are removing semicolons anyway, I think we can safely disable the
no-extra-semirule.