Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused got dependency #6625

Merged
merged 1 commit into from
May 17, 2024
Merged

fix: remove unused got dependency #6625

merged 1 commit into from
May 17, 2024

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented May 17, 2024

Summary

As of #6235 got is no longer used in this repository so let's remove it from dependencies!


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@mrstork mrstork requested a review from a team as a code owner May 17, 2024 13:50
Copy link

πŸ“Š Benchmark results

Comparing with 5c49780

  • Dependency count: 1,359 (no change)
  • Package size: 313 MB ⬇️ 0.00% decrease vs. 5c49780
  • Number of ts-expect-error directives: 980 (no change)

@mrstork mrstork merged commit e710f1e into main May 17, 2024
48 checks passed
@mrstork mrstork deleted the remove-dependency-got branch May 17, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants