fix: serve function support in monorepos #6608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahetter
previously approved these changes
May 16, 2024
mrstork
force-pushed
the
serve-monorepos-functions-support
branch
from
698d665
to
7e934ce
Compare
mrstork
force-pushed
the
serve-monorepos-functions-support
branch
from
7e934ce
to
0cae1d5
Compare
sarahetter
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #CT-1145
ntl servewas skipping includingfunctions-internal,functions-dist, andfunctions-servebecause it wasn't able to locate them. Adding the package path into the function call resolves the issue.Tested with a next monorepo
Before:
After:
(Even though it's an error, we know it's being registered now)