Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): fix don't cache npm cache dir between workflow execs #3277

Merged
merged 1 commit into from Aug 31, 2021
Merged

chore(ci): fix don't cache npm cache dir between workflow execs #3277

merged 1 commit into from Aug 31, 2021

Conversation

JGAntunes
Copy link
Member

@JGAntunes JGAntunes commented Aug 31, 2021 •
edited

Reverts - 9e7f417 - caching only seems to work with package-lock.json files and doesn't seem to support npm-shrinkwrap (see https://github.com/netlify/cli/runs/3471879986) (EDIT: the path for the lockfile can be configured apparently - actions/setup-node#302)

@JGAntunes JGAntunes self-assigned this Aug 31, 2021
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Aug 31, 2021
@github-actions
Copy link

github-actions bot commented Aug 31, 2021 •
edited

📊 Benchmark results

Package size: 327 MB

^  327 MB 
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T
Legend
  • T (current commit): 327 MB

@JGAntunes JGAntunes added automerge Add to Kodiak auto merge queue and removed automerge Add to Kodiak auto merge queue labels Aug 31, 2021
@JGAntunes
Copy link
Member Author

JGAntunes commented Aug 31, 2021 •
edited

Apologies @erezrokah I ended up finding - actions/setup-node#302 - so I dismissed your original review. This change should put the cache in a working state 👍

@JGAntunes JGAntunes added the automerge Add to Kodiak auto merge queue label Aug 31, 2021
@kodiakhq kodiakhq bot merged commit 4f4388b into main Aug 31, 2021
@kodiakhq kodiakhq bot deleted the chore/fix-ci-npm-cache branch August 31, 2021 11:51
@JGAntunes
Copy link
Member Author

Related with https://github.com/netlify/team-dev/issues/31

@JGAntunes JGAntunes mentioned this pull request Sep 13, 2021
Merged
@erezrokah erezrokah mentioned this pull request Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

@ehmicky ehmicky Awaiting requested review from ehmicky

Assignees

@JGAntunes JGAntunes

Labels
automerge Add to Kodiak auto merge queue type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JGAntunes @erezrokah