Skip to content

Commit

Permalink
chore: fix the todo and other suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
lukasholzer committed Aug 10, 2023
1 parent 908db2f commit 0bee796
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/commands/base-command.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ export default class BaseCommand extends Command {
// api methods
api,
apiOpts,
// The Absolute Repository root (detected through @netlify/config)
// The absolute repository root (detected through @netlify/config)
repositoryRoot,
configFilePath,
relConfigFilePath: relative(repositoryRoot, configFilePath),
Expand Down
10 changes: 4 additions & 6 deletions src/commands/deploy/deploy.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -422,9 +422,10 @@ const handleBuild = async ({ cachedConfig, options }) => {
/**
*
* @param {object} options Bundling options
* @param {import('..//base-command.mjs').default} command
* @returns
*/
const bundleEdgeFunctions = async (options) => {
const bundleEdgeFunctions = async (options, command) => {
const statusCb = options.silent ? () => {} : deployProgressCb()

statusCb({
Expand All @@ -435,8 +436,7 @@ const bundleEdgeFunctions = async (options) => {

const { severityCode, success } = await runCoreSteps(['edge_functions_bundling'], {
...options,
// TODOL: add package path here
packagePath: 'todo',
packagePath: command.workspacePackage,
buffer: true,
featureFlags: edgeFunctionsFeatureFlags,
})
Expand Down Expand Up @@ -596,7 +596,7 @@ const deploy = async (options, command) => {

// build flag wasn't used and edge functions exist
if (!options.build && edgeFunctionsConfig && edgeFunctionsConfig.length !== 0) {
await bundleEdgeFunctions(options)
await bundleEdgeFunctions(options, command)
}

log(
Expand Down Expand Up @@ -638,8 +638,6 @@ const deploy = async (options, command) => {
context: command.netlify.cachedConfig.context,
branch: command.netlify.cachedConfig.branch,
})
// console.log('skipping deploy')
// exit(1)
const results = await runDeploy({
alias,
api,
Expand Down

0 comments on commit 0bee796

Please sign in to comment.