Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Psalm to ^5 #223

Merged
merged 2 commits into from
May 4, 2023
Merged

Upgrade Psalm to ^5 #223

merged 2 commits into from
May 4, 2023

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented May 4, 2023

Closes #200

@gsteel gsteel added enhancement New feature or request dependencies Pull requests that update a dependency file labels May 4, 2023
@gsteel gsteel added this to the 1.4.0 milestone May 4, 2023
@gsteel gsteel self-assigned this May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.59 🎉

Comparison is base (10bf4bf) 84.00% compared to head (1e3b767) 84.60%.

❗ Current head 1e3b767 differs from pull request most recent head 494184b. Consider uploading reports for the commit 494184b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##              1.4.x     #223      +/-   ##
============================================
+ Coverage     84.00%   84.60%   +0.59%     
  Complexity      203      203              
============================================
  Files            37       37              
  Lines           619      643      +24     
============================================
+ Hits            520      544      +24     
  Misses           99       99              
Impacted Files Coverage Δ
src/ResultSet/HydratingResultSetFactory.php 9.52% <ø> (ø)
...dleware/Container/ExpiredPreviewHandlerFactory.php 100.00% <100.00%> (ø)
src/Middleware/Container/PreviewHandlerFactory.php 100.00% <100.00%> (ø)
...rc/Middleware/Container/PrismicTemplateFactory.php 100.00% <100.00%> (ø)
src/Middleware/Container/WebhookHandlerFactory.php 100.00% <100.00%> (ø)
src/ResultSet/Container/TypeMapFactory.php 100.00% <100.00%> (ø)
src/ResultSet/TypeMap.php 100.00% <100.00%> (ø)
src/RouteProvider.php 100.00% <100.00%> (ø)
src/Router/Container/RouteParamsFactory.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gsteel gsteel merged commit 14be174 into 1.4.x May 4, 2023
12 checks passed
@gsteel gsteel deleted the psalm5 branch May 4, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant