Merge pull request #10515 from buddh4/feat-custom-file-pipe-builder-v…

…alidators feat(common): Allow adding custom validators to ParseFilePipeBuilder
nestjs · Nov 7, 2022 · 9ffdffd · 9ffdffd
2 parents 8039161 + a4a4d57
commit 9ffdffd
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 3 deletions.
diff --git a/packages/common/pipes/file/parse-file-pipe.builder.ts b/packages/common/pipes/file/parse-file-pipe.builder.ts
@@ -14,12 +14,15 @@ export class ParseFilePipeBuilder {
   private validators: FileValidator[] = [];
 
   addMaxSizeValidator(options: MaxFileSizeValidatorOptions) {
-    this.validators.push(new MaxFileSizeValidator(options));
-    return this;
+    return this.addValidator(new MaxFileSizeValidator(options));
   }
 
   addFileTypeValidator(options: FileTypeValidatorOptions) {
-    this.validators.push(new FileTypeValidator(options));
+    return this.addValidator(new FileTypeValidator(options));
+  }
+
+  addValidator(validator: FileValidator) {
+    this.validators.push(validator);
     return this;
   }
 

diff --git a/packages/common/test/pipes/file/parse-file-pipe.builder.spec.ts b/packages/common/test/pipes/file/parse-file-pipe.builder.spec.ts
@@ -1,6 +1,8 @@
 import { expect } from 'chai';
 import {
   FileTypeValidator,
+  FileTypeValidatorOptions,
+  FileValidator,
   MaxFileSizeValidator,
   ParseFilePipeBuilder,
 } from '../../../pipes';
@@ -50,6 +52,32 @@ describe('ParseFilePipeBuilder', () => {
       });
     });
 
+    describe('when custom validator was chained', () => {
+      it('should return a ParseFilePipe with TestFileValidator and given options', () => {
+        class TestFileValidator extends FileValidator<{ name: string }> {
+          buildErrorMessage(file: any): string {
+            return 'TestFileValidator failed';
+          }
+
+          isValid(file: any): boolean | Promise<boolean> {
+            return true;
+          }
+        }
+
+        const options = {
+          name: 'test',
+        };
+
+        const parseFilePipe = parseFilePipeBuilder
+          .addValidator(new TestFileValidator(options))
+          .build();
+
+        expect(parseFilePipe.getValidators()).to.deep.include(
+          new TestFileValidator(options),
+        );
+      });
+    });
+
     describe('when it is called twice with different validators', () => {
       it('should not reuse validators', () => {
         const maxSizeValidatorOptions = {