feat(new): support to skip install #1458

zanminkian · 2021-12-17T15:37:56Z

If I run command nest new some-project (some one new may don't know --skip-install option), nest-cli always force me to select a package manager. I have to press ctrl + c to skip, which is not elegant. Otherwise I have to waste my time to wait it.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

zanminkian · 2021-12-17T15:43:59Z

actions/new.action.ts

@@ -225,16 +218,18 @@ const printCollective = () => {
  emptyLine();
 };

-const print = (color: string | null = null) => (str = '') => {


prettier automatically format it.

jmcdo29

LGTM

kamilmysliwiec · 2021-12-20T07:37:11Z

Should we update this new option to say "none (skip installing packages)" instead of just "none" as one (newcomers to JS world) can think there's a "none" package manager? 😅

zanminkian · 2021-12-20T09:04:20Z

Should we update this new option to say "none (skip installing packages)" instead of just "none" as one (newcomers to JS world) can think there's a "none" package manager? 😅

@kamilmysliwiec Good idea. Done now.

jmcdo29

LGTM

micalevisk · 2021-12-20T17:01:16Z

lib/package-managers/package-manager.ts

@@ -1,5 +1,6 @@
 export enum PackageManager {
  NPM = 'npm',
  YARN = 'yarn',
-  PNPM = 'pnpm'
+  PNPM = 'pnpm',
+  NONE = 'none (skip installing packages)',


I just notice something. If none is selected, then npm will be used by default on generated files (eg: README.md with usage commands) due to the following lines on application schematics

https://github.com/nestjs/schematics/blob/440d06d6217e40ca334be635d5264aac6dda8002/src/lib/application/application.factory.ts#L43-L46

thus, wouldn't be better if

Suggested change

NONE = 'none (skip installing packages)',

NONE = 'none (use NPM but without installing packages)',

or even

Suggested change

NONE = 'none (skip installing packages)',

NONE = 'NPM but without installing packages',

actually, the selected option is not taken in count for now but this is bug that was already fixed by #1457, so you could think it is.

zanminkian · 2021-12-21T03:08:59Z

@micalevisk I found it's not very elegant. I will convert this PR to draft.
The elegant way is asking user 2 questions:

Which package manager would you like to use?

npm
yarn
pnpm

Install packages now?

Yes
No

The first question is to generate README.md.
The second question is to skip installing or not.

What your opinion? @micalevisk @kamilmysliwiec @jmcdo29

micalevisk · 2021-12-21T04:03:29Z

having two questions is better for sure.

zanminkian · 2021-12-21T09:20:05Z

@micalevisk I found it's not very elegant. I will convert this PR to draft. The elegant way is asking user 2 questions:

Which package manager would you like to use?

npm

yarn

pnpm

Install packages now?

Yes

No

The first question is to generate README.md. The second question is to skip installing or not.

What your opinion? @micalevisk @kamilmysliwiec @jmcdo29

After PR #1457 being accepted, I will implement this feature.

kamilmysliwiec · 2021-12-21T09:20:10Z

IMO the fewer questions we could ask the better (to make the scaffolding process as straightforward & quick as possible)

zanminkian · 2021-12-21T09:28:56Z

IMO the fewer questions we could ask the better (to make the scaffolding process as straightforward & quick as possible)

Got it. And I found #1457 has code conflict with this PR. After that PR being accepted, I will rebase and ask for review again.

micalevisk · 2021-12-21T12:38:06Z

to make the scaffolding process as straightforward & quick as possible

that's a good point acctually. Then, I go back to #1458 (comment) xD

kamilmysliwiec · 2022-12-27T11:10:55Z

This should be feasible now (since we merged #1803)

zanminkian commented Dec 17, 2021

View reviewed changes

jmcdo29 approved these changes Dec 17, 2021

View reviewed changes

micalevisk approved these changes Dec 19, 2021

View reviewed changes

feat(new): support to skip install

d6bd867

zanminkian force-pushed the feat/support-to-skip-install branch from 8797cb1 to d6bd867 Compare December 20, 2021 09:00

jmcdo29 approved these changes Dec 20, 2021

View reviewed changes

micalevisk reviewed Dec 20, 2021

View reviewed changes

zanminkian marked this pull request as draft December 21, 2021 09:26

micalevisk mentioned this pull request Jan 19, 2022

Fix support for package manager selection, and refactoring new command/action #1457

Closed

3 tasks

Tony133 approved these changes Mar 16, 2022

View reviewed changes

micalevisk mentioned this pull request Feb 15, 2023

--skip-install should not ask for the package manager #1936

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(new): support to skip install #1458

feat(new): support to skip install #1458

zanminkian commented Dec 17, 2021 •

edited

zanminkian Dec 17, 2021

jmcdo29 left a comment

kamilmysliwiec commented Dec 20, 2021

zanminkian commented Dec 20, 2021

jmcdo29 left a comment

micalevisk Dec 20, 2021 •

edited

micalevisk Dec 20, 2021 •

edited

zanminkian commented Dec 21, 2021

micalevisk commented Dec 21, 2021

zanminkian commented Dec 21, 2021

kamilmysliwiec commented Dec 21, 2021

zanminkian commented Dec 21, 2021

micalevisk commented Dec 21, 2021

kamilmysliwiec commented Dec 27, 2022

	NONE = 'none (skip installing packages)',
	NONE = 'none (use NPM but without installing packages)',

	NONE = 'none (skip installing packages)',
	NONE = 'NPM but without installing packages',

feat(new): support to skip install #1458

Are you sure you want to change the base?

feat(new): support to skip install #1458

Conversation

zanminkian commented Dec 17, 2021 • edited

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

zanminkian Dec 17, 2021

Choose a reason for hiding this comment

jmcdo29 left a comment

Choose a reason for hiding this comment

kamilmysliwiec commented Dec 20, 2021

zanminkian commented Dec 20, 2021

jmcdo29 left a comment

Choose a reason for hiding this comment

micalevisk Dec 20, 2021 • edited

Choose a reason for hiding this comment

micalevisk Dec 20, 2021 • edited

Choose a reason for hiding this comment

zanminkian commented Dec 21, 2021

micalevisk commented Dec 21, 2021

zanminkian commented Dec 21, 2021

kamilmysliwiec commented Dec 21, 2021

zanminkian commented Dec 21, 2021

micalevisk commented Dec 21, 2021

kamilmysliwiec commented Dec 27, 2022

zanminkian commented Dec 17, 2021 •

edited

micalevisk Dec 20, 2021 •

edited

micalevisk Dec 20, 2021 •

edited