Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use @nestjs/class-validator #745

Closed

Conversation

elliotttf
Copy link

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: this updates the version of class-validator in use to be @nestjs/class-validator which addresses the Improper Input Validation vulnerability identified by SNYK-JS-CLASSVALIDATOR-1730566

What is the current behavior?

Issue Number: typestack/class-validator#1443

What is the new behavior?

Behavior is unchanged, only the imports have been updated.

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe... class-validator was an optional peer dependency, so code will not outright break, but it could be misleading for dependent modules. In order to preserve 1:1 behavior, dependents would need to remove class-validator and add @nestjs/class-validator in its place.

@kamilmysliwiec
Copy link
Member

Thanks for your suggestion!

This has been discussed in the past and we decided to not migrate it in the foreseeable future.

If you think your request could live outside Nest's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

@nestjs nestjs locked and limited conversation to collaborators Jun 13, 2022
@elliotttf elliotttf deleted the fix/nestjs-class-validator branch July 1, 2022 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants