Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docs for repl v9 feature #2361

Closed
wants to merge 22 commits into from
Closed

feat: add docs for repl v9 feature #2361

wants to merge 22 commits into from

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Jun 19, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the new behavior?

documentation for the feature introduce by this PR: nestjs/nest#9684 that will be available on NestJS v9.

Does this PR introduce a breaking change?

  • Yes
  • No

ppodds and others added 21 commits January 21, 2022 19:16
Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
Add example usage of INQUIRER injection token to provider-scopes section.

closes #937
Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
Co-authored-by: bennyk9y <96472716+bennyk9y@users.noreply.github.com>
…provider-scopes

docs(provider-scopes): add documentation for `INQUIRER` scope
docs(faq,techniques): add resolution for "can't resolve ModuleRef"; add missing docs on `axiosRef`
docs(sql): add @nestjs/typeorm issue 86 solution
content/recipes/repl.md Outdated Show resolved Hide resolved
@micalevisk micalevisk marked this pull request as ready for review June 20, 2022 11:06
content/recipes/repl.md Outdated Show resolved Hide resolved
Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micalevisk micalevisk marked this pull request as draft June 21, 2022 17:52
@micalevisk micalevisk marked this pull request as ready for review June 23, 2022 00:04
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 9.0.0 June 23, 2022 12:27
@kamilmysliwiec
Copy link
Member

I had to rebase & cherry-pick commits from that branch to v9.0.0. Merged it locally but it doesn't propagate to Github so I'm gonna close this PR. Thank you @micalevisk!

Here's the commit ref cc41c3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants