95 openpyxl selenium imports #96
Conversation
| @@ -70,26 +74,32 @@ def _save_png( | |||
| ) | |||
|
|
|||
|
|
|||
| def _save_html(fig: Chart, path: os.PathLike, name: str, scale_factor: int): | |||
| def _save_html( | |||
There was a problem hiding this comment.
Tiny tiny aesthetic comment so please feel free to ignore, but I noticed you separated out parameters into different lines for _save_svg and _save_png but haven't here.
There was a problem hiding this comment.
The pre-commit linting checks made these changes to separate lines if the line exceeds a (PEP8?) character count (should be ~80?)
…ting enabled features
| @@ -0,0 +1,9 @@ | |||
| from nesta_ds_utils.loading_saving.gis_interface import _gis_enabled | |||
There was a problem hiding this comment.
Would it make sense to move the gis_interface try except into here as well? Instead of importing?
There was a problem hiding this comment.
I'd keep less logic in init.py , the imports are needed for defining the functions in gis_interface anyways. So I'd tend towards importing by traversing up the directory tree to the top level features_enabled dict
Update some more dependencies
This PR closes the issues: #95
This PR also partially addresses: #89
Description
openpyxlbackendpathparameters in function signatures inviz.altair.saving.py__init__.pyto package modulesChecklist:
>> pytest