refactor(DB): replace rbatis with sqlx #424

EthanYuan · 2022-06-07T10:01:02Z

What this PR does / why we need it:

replace rbatis with sqlx

replace rbatis with sqlx v0.6
use AnyPool of sqlx, this supports both Postgres and Sqlite(unit test)
remove unused tracing crate: resolve compilation conflicts with sqlx v0.6.0
limit the maximum value of the field limit in PaginationRequest to u16::MAX(65535)
remove config filed db_log_level

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

core/storage/src/relational/fetch.rs

core/storage/src/relational/mod.rs

core/storage/src/relational/tests/fetch_mod_test.rs

core/storage/src/relational/fetch.rs

core/storage/src/relational/insert.rs

more than 1000.

…ment.

…ACE.

EthanYuan requested a review from quake June 7, 2022 10:01

EthanYuan force-pushed the dev-0.4-db branch 2 times, most recently from 53d54a0 to b3ad404 Compare June 13, 2022 11:58

EthanYuan force-pushed the dev-0.4-db branch 2 times, most recently from 7adcd6d to 97e2082 Compare June 20, 2022 10:29

EthanYuan added 25 commits July 7, 2022 22:06

remove unused code.

6343acd

add sqlx crate.

591c82e

add db-sqlx crate.

661503f

add mod PgSqlx.

1215722

impl query_block_x by sqlx.

7cfab8a

clean unused dep.

09f6117

use sqlx::Any for both pg and sqlite(test).

462d74b

add fetch_count for SQLXPool.

baacaa0

refactoring db-sqlx.

1814970

refacotring.

5c72c58

use QueryAs as sql builder.

d871d69

refactoring.

119602c

update dep crate path

2ad47b5

refactoring: remove the concrete type mapped to a table.

c3696bb

refactoring: query_tip

bb39e42

add unit tests.

bc59ee4

refactoring.

4d6baf2

impl get_transactions_with_status by input AnyRow.

83522b8

impl query_simple_transaction by sqlx.

af4d2df

impl query_spent_tx_hash by sqlx.

82f1534

add fetch_optional for SQLXPool.

b9f31c0

impl fetch::query_transactions by sqlx.

5c5af63

Limit the value range of limit from u64 to u16.

ce9ad30

rm unused code.

720427c

use fetch instead of fetch_all

f35a7b3

EthanYuan added 12 commits July 26, 2022 09:45

add block_view build test.

90c5b38

impl by sqlx in sql mod in synchronization crate.

9b9242a

update insert_block to bulk_insert_blocks.

74d5e5c

add insert_live_cells para in bulk_insert_output_cells in storage.

81659f7

impl sync_blocks by sqlx in Task mod.

96865bb

impl set_state_cursor in sync task mod by sqlx.

11cfdda

impl sync_indexer_cells in sync task mod by sqlx.

53555e6

rm rbatis deps.

40c5895

fix sql query error.

cb49658

add indexer cells table check in unit test.

9cfea29

rm tracing crate: resolve compilation conflicts with sqlx v0.6.0.

b09b31c

try impl H256 decode for sqlx.

be5fbf3

EthanYuan marked this pull request as ready for review July 29, 2022 05:49

quake reviewed Aug 1, 2022

View reviewed changes

EthanYuan added 12 commits August 2, 2022 00:04

Modifications based on review suggestions.

c2daae7

Modification as suggested by review: remove explicit type annotations

be0dca0

fix rollback_consume_cell sql.

55fa8db

refactoring code in storage::relational::remove;

e9bc69a

remove unused code.

c77b5aa

fix bulk insert binding when the batch rows number

2a34a88

more than 1000.

update sqlx to 0.6.1

0e26605

update db_log_level in config to override sqlx log level.

12fc746

fix fmt.

ef199a6

fix: Postgres doesn't support multiple commands in one prepared state…

2195910

…ment.

remove the config filed db_log_level and overide sqlx log level to TR…

f90ce85

…ACE.

fix bind type mismatched.

63ce242

EthanYuan requested a review from quake August 12, 2022 03:15

quake approved these changes Aug 26, 2022

View reviewed changes

EthanYuan merged commit e1896e4 into nervosnetwork:dev-0.4 Aug 26, 2022

EthanYuan deleted the dev-0.4-db branch August 29, 2022 03:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(DB): replace rbatis with sqlx #424

refactor(DB): replace rbatis with sqlx #424

EthanYuan commented Jun 7, 2022 •

edited

refactor(DB): replace rbatis with sqlx #424

refactor(DB): replace rbatis with sqlx #424

Conversation

EthanYuan commented Jun 7, 2022 • edited

EthanYuan commented Jun 7, 2022 •

edited