Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed entrypoint upload on Windows when entrypoint and source files doesnt share same drive #1161

Merged
merged 5 commits into from Dec 13, 2022

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Dec 12, 2022

No description provided.

@Raalsky Raalsky changed the title Entrypoint path taken into account when looking for a common path Fixed entrypoint upload on Windows when paths doesnt share same drive Dec 12, 2022
@Raalsky Raalsky changed the title Fixed entrypoint upload on Windows when paths doesnt share same drive Fixed entrypoint upload on Windows when entrypoint and source files doesnt share same drive Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 73.41% // Head: 71.14% // Decreases project coverage by -2.27% ⚠️

Coverage data is based on head (2f960ad) compared to base (b684180).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
- Coverage   73.41%   71.14%   -2.28%     
==========================================
  Files         283      283              
  Lines       13378    13379       +1     
==========================================
- Hits         9822     9518     -304     
- Misses       3556     3861     +305     
Flag Coverage Δ
unit 71.14% <100.00%> (-2.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/new/internal/utils/__init__.py 79.77% <100.00%> (+0.46%) ⬆️
src/neptune/new/internal/utils/source_code.py 96.00% <100.00%> (-0.16%) ⬇️
src/neptune/legacy/model.py 51.19% <0.00%> (-27.39%) ⬇️
src/neptune/common/hardware/gauges/gauge.py 55.55% <0.00%> (-22.23%) ⬇️
...ptune/legacy/internal/api_clients/client_config.py 72.72% <0.00%> (-21.22%) ⬇️
src/neptune/legacy/backend.py 47.89% <0.00%> (-21.01%) ⬇️
...c/neptune/common/hardware/system/system_monitor.py 66.66% <0.00%> (-20.00%) ⬇️
.../common/hardware/resources/system_resource_info.py 76.00% <0.00%> (-20.00%) ⬇️
src/neptune/common/hardware/metrics/metric.py 80.85% <0.00%> (-19.15%) ⬇️
...neptune/legacy/internal/utils/alpha_integration.py 41.66% <0.00%> (-17.50%) ⬇️
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Raalsky
Copy link
Contributor Author

Raalsky commented Dec 12, 2022

/run-e2e

@neptune-bot
Copy link

Hey hey @Raalsky! I'm glad to see that you're looking for something much more demanding 😉 I've triggered for you our E2E tests on every supported Operating System and Python version. Check current status here 🚀

@shnela shnela merged commit a815357 into master Dec 13, 2022
@shnela shnela deleted the rj/windows-source-files branch December 13, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants