Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit do disk queue #1089

Merged
merged 11 commits into from Nov 18, 2022
Merged

Add limit do disk queue #1089

merged 11 commits into from Nov 18, 2022

Conversation

pankin397
Copy link
Contributor

Now there is a limited batch size that can be pulled out of disk_queue.get_batch(), it's determined by the MAX_BATCH_SIZE env variable.

@pankin397 pankin397 self-assigned this Nov 14, 2022
@github-actions
Copy link

github-actions bot commented Nov 14, 2022

Test Results

       2 files   -      11         2 suites   - 11   1m 12s ⏱️ - 22m 51s
   502 tests  -    222     502 ✔️  -    215  0 💤  -   3  0  - 4 
1 004 runs   - 5 220  1 004 ✔️  - 5 119  0 💤  - 97  0  - 4 

Results for commit 00e21dc. ± Comparison against base commit 22fffd1.

This pull request removes 224 and adds 2 tests. Note that renamed tests count towards both.
management.test_management.TestManagement ‑ test_create_project
management.test_management.TestManagement ‑ test_invite_as_non_admin
management.test_management.TestManagement ‑ test_standard_scenario
management.test_management.TestManagement ‑ test_visibility_workspace
management.test_management.TestTrashObjects ‑ test_trash_model_version
management.test_management.TestTrashObjects ‑ test_trash_runs_and_models
standard.test_artifacts.TestArtifacts ‑ test_assignment[model]
standard.test_artifacts.TestArtifacts ‑ test_assignment[model_version]
standard.test_artifacts.TestArtifacts ‑ test_assignment[project]
standard.test_artifacts.TestArtifacts ‑ test_assignment[run]
…
tests.neptune.new.internal.test_disk_queue.TestDiskQueue ‑ test_batch_limit
tests.neptune.new.internal.utils.test_json_file_splitter.TestJsonFileSplitter ‑ test_data_size

♻️ This comment has been updated with latest results.

src/neptune/new/internal/disk_queue.py Outdated Show resolved Hide resolved
src/neptune/new/internal/disk_queue.py Outdated Show resolved Hide resolved
src/neptune/new/internal/disk_queue.py Outdated Show resolved Hide resolved
src/neptune/new/internal/disk_queue.py Outdated Show resolved Hide resolved
src/neptune/new/internal/disk_queue.py Outdated Show resolved Hide resolved
src/neptune/new/internal/disk_queue.py Show resolved Hide resolved
src/neptune/new/internal/disk_queue.py Outdated Show resolved Hide resolved
Pavel Sankin and others added 2 commits November 17, 2022 18:56
@pankin397 pankin397 merged commit b52f4ca into master Nov 18, 2022
@pankin397 pankin397 deleted the add_limit_do_disk_queue branch November 18, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants