Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track artifacts on S3 compatible storage #1053

Merged
merged 4 commits into from Oct 25, 2022
Merged

Track artifacts on S3 compatible storage #1053

merged 4 commits into from Oct 25, 2022

Conversation

shnela
Copy link
Contributor

@shnela shnela commented Oct 21, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 21, 2022 •
edited

Test Results

    2 files  ±    0      2 suites  ±0   1m 56s ⏱️ - 26m 9s
482 tests +215  482 ✔️ +220  0 💤  - 5  0 ❌ ±0 
964 runs  +697  964 ✔️ +702  0 💤  - 5  0 ❌ ±0 

Results for commit 56b00c2. ± Comparison against base commit 9a0e977.

This pull request removes 267 and adds 482 tests. Note that renamed tests count towards both. 
integrations.test_huggingface.TestHuggingFace ‑ test_every_train_should_create_new_run
integrations.test_huggingface.TestHuggingFace ‑ test_hyperparameter_optimization
integrations.test_huggingface.TestHuggingFace ‑ test_initialization_with_run_provided
integrations.test_huggingface.TestHuggingFace ‑ test_integration_version_is_logged
integrations.test_huggingface.TestHuggingFace ‑ test_log_parameters_disabled
integrations.test_huggingface.TestHuggingFace ‑ test_log_parameters_with_base_namespace
integrations.test_huggingface.TestHuggingFace ‑ test_log_with_custom_base_namespace
integrations.test_huggingface.TestHuggingFace ‑ test_model_checkpoints_best[checkpoint_settings0]
integrations.test_huggingface.TestHuggingFace ‑ test_model_checkpoints_best[checkpoint_settings1]
integrations.test_huggingface.TestHuggingFace ‑ test_model_checkpoints_best[checkpoint_settings2]
…

tests.neptune.alpha_integration.test_alpha_integration_backend.TestAlphaIntegrationNeptuneBackend ‑ test_send_channels_image_values
tests.neptune.alpha_integration.test_alpha_integration_backend.TestAlphaIntegrationNeptuneBackend ‑ test_send_channels_numeric_values
tests.neptune.alpha_integration.test_alpha_integration_backend.TestAlphaIntegrationNeptuneBackend ‑ test_send_channels_text_values
tests.neptune.legacy.internal.backends.test_hosted_neptune_backend.TestHostedNeptuneBackend ‑ test_cannot_resolve_host
tests.neptune.legacy.internal.backends.test_hosted_neptune_backend.TestHostedNeptuneBackend ‑ test_deprecated_token
tests.neptune.legacy.internal.backends.test_hosted_neptune_backend.TestHostedNeptuneBackend ‑ test_max_compatible_version_fail
tests.neptune.legacy.internal.backends.test_hosted_neptune_backend.TestHostedNeptuneBackend ‑ test_max_compatible_version_ok
tests.neptune.legacy.internal.backends.test_hosted_neptune_backend.TestHostedNeptuneBackend ‑ test_min_compatible_version_fail
tests.neptune.legacy.internal.backends.test_hosted_neptune_backend.TestHostedNeptuneBackend ‑ test_min_compatible_version_ok
tests.neptune.legacy.internal.backends.test_hosted_neptune_backend.TestHostedNeptuneBackend ‑ test_should_accept_given_api_token
…

♻️ This comment has been updated with latest results.

Raalsky
Raalsky reviewed Oct 25, 2022
View reviewed changes
src/neptune/new/internal/artifacts/drivers/s3.py Show resolved Hide resolved
src/neptune/new/internal/artifacts/drivers/s3.py Outdated
boto3 `endpoint_url` support PR:
* https://github.com/boto/boto3/pull/2746
"""
endpoint_url = os.getenv("S3_ENDPOINT_URL")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this should be a part of neptune.new.envs

Raalsky
Raalsky reviewed Oct 25, 2022
View reviewed changes
CHANGELOG.md Outdated
@@ -11,6 +11,7 @@
- `get_last_run`, `get_run_url`, `get_project` and `neptune.init` marked as deprecated ([#1011](https://github.com/neptune-ai/neptune-client/pull/1011))
- Deprecated implicit casting of objects to strings with `log` and `assign` operations ([#1028](https://github.com/neptune-ai/neptune-client/pull/1028))
- Internally extracted legacy client to `legacy` submodule ([#1039](https://github.com/neptune-ai/neptune-client/pull/1039))
- Track artifacts on S3 compatible storage ([#1053](https://github.com/neptune-ai/neptune-client/pull/1053))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be treated as a feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

@shnela shnela merged commit 7e19d89 into master Oct 25, 2022
@shnela shnela deleted the jk/artifacts-s3 branch October 25, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raalsky Raalsky Raalsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shnela @Raalsky