Upload in-memory files using copy stored on disk #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shnela
force-pushed
the
jk/upload-through-hd
branch
from
4e5021b
to
32986ed
Compare
Raalsky
reviewed
Oct 26, 2022
| @@ -29,6 +30,10 @@ class OperationStorage: | |||
| def __init__(self, data_path: str): | |||
| self._data_path = Path(data_path) | |||
|
|
|||
| # initialize directories | |||
| os.makedirs(self.data_path) | |||
There was a problem hiding this comment.
Definitelly, good catch!
| def get_upload_path(attribute_path: List[str], extension: str, upload_path: Path): | ||
| now = datetime.now() | ||
| tmp_file_name = f"{'_'.join(attribute_path)}-{now.timestamp()}-{now}.{extension}" | ||
| tmp_file_name = tmp_file_name.replace(" ", "_").replace(":", ".") |
There was a problem hiding this comment.
What about just proper strftime() instead of these bad looking replace calls?
There was a problem hiding this comment.
I've used to copy-paste this code over and over...
Yes, it's better idea ;)
Raalsky
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.