Automatically convert image and html like assignments to uploads #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shnela
force-pushed
the
jk/assign-plot-objects
branch
from
bdb5a00
to
d0dce06
Compare
Test Results 2 files - 38 2 suites - 38 1m 48s ⏱️ - 3h 49m 14s Results for commit a11c8f9. ± Comparison against base commit 497347c. This pull request removes 691 and adds 484 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
shnela
force-pushed
the
jk/assign-plot-objects
branch
from
d0dce06
to
30e4767
Compare
shnela
force-pushed
the
jk/assign-plot-objects
branch
from
e1bc8bb
to
235922c
Compare
Raalsky
reviewed
Nov 4, 2022
| from neptune.new.types.value_copy import ValueCopy | ||
|
|
||
|
|
||
| def cast_value(value: Any) -> Value: |
There was a problem hiding this comment.
As we extracted this func (which is so cool!) what do you think about using a single-dispatch? https://docs.python.org/3.7/library/functools.html#functools.singledispatch You should be able to split this function into multiple one that will be triggered base on arguments type.
There was a problem hiding this comment.
I think it's a good idea.
Let's try it.
There was a problem hiding this comment.
Or maybe not.
We do casting not only based on type, but also on predicate which looks like it's not supported by singledispatch.
| @@ -14,14 +14,12 @@ | |||
| # limitations under the License. | |||
Raalsky
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.