Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting altair workaround #190

Merged
merged 1 commit into from Jan 27, 2023
Merged

Conversation

SiddhantSadangi
Copy link
Member

Description

Reverts workaround applied for Altair in #183 as the issue has been fixed from Altair's end (vega/altair#2771)

Related to: fix test errors

Any expected test failures?


Add a [X] to relevant checklist items

❔ This change

  • adds a new feature
  • fixes breaking code
  • is cosmetic (refactoring/reformatting)

✔️ Pre-merge checklist

  • Refactored code (sourcery)
  • Tested code locally
  • Precommit installed and run before pushing changes
  • Added code to GitHub tests (notebooks, scripts)
  • Updated GitHub README
  • Updated the projects overview page on Notion

🧪 Test Configuration

  • OS: Windows11
  • Python version: 3.7, 3.8,3.9, 3.10, 3.11
  • Neptune version: 0.16.16
  • Affected libraries with version: altair==4.2.1

Copy link
Contributor

@Blaizzy Blaizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SiddhantSadangi SiddhantSadangi merged commit 478bc83 into main Jan 27, 2023
@SiddhantSadangi SiddhantSadangi deleted the ss/reverting_altair_patch branch January 27, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants