Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pip install - I #168

Merged
merged 1 commit into from Dec 28, 2022
Merged

Fix pip install - I #168

merged 1 commit into from Dec 28, 2022

Conversation

SiddhantSadangi
Copy link
Member

@SiddhantSadangi SiddhantSadangi commented Dec 27, 2022 •
edited

Description

  • Unpinned dependencies
  • Added -U and removed -q flags from pip install
  • Added -e flag to run_examples.sh

Note:

Related to: fix test errors

❔ This change

  • adds a new feature
  • fixes breaking code
  • is cosmetic (refactoring/reformatting)

✔️ Pre-merge checklist

Mark which items have been completed:

🪝 Run the following to both pre-commit hooks and JupyterLab (turn on format on save)

  • Stripped outputs from notebooks - (nbstripout)
  • Sorted imports - (isort)
  • Formatted code - (back)

🧪 Test Configuration

  • OS:
  • Python version:
  • Neptune version:
  • Affected libraries with version:

@SiddhantSadangi SiddhantSadangi self-assigned this Dec 27, 2022
@SiddhantSadangi SiddhantSadangi marked this pull request as ready for review December 27, 2022 17:14
Blaizzy
Blaizzy reviewed Dec 28, 2022
View reviewed changes
Copy link
Contributor

@Blaizzy Blaizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you format it with black?

how-to-guides/how-it-works/notebooks/Neptune_API_Tour.ipynb Show resolved Hide resolved
Blaizzy
Blaizzy approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@Blaizzy Blaizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SiddhantSadangi SiddhantSadangi merged commit 802fccb into main Dec 28, 2022
@SiddhantSadangi SiddhantSadangi deleted the ss/fix-pip-install branch December 28, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blaizzy Blaizzy Blaizzy approved these changes

Assignees

@SiddhantSadangi SiddhantSadangi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SiddhantSadangi @Blaizzy