feat(eslint): support yarn2 PnP projects #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamboman
commented
Mar 14, 2022
Comment on lines
+112
to
+104
| local pnp_cjs = util.path.join(new_root_dir, '.pnp.cjs') | ||
| local pnp_js = util.path.join(new_root_dir, '.pnp.js') |
There was a problem hiding this comment.
Globbing might be nicer here, but wanted to avoid vim.fn call.
There was a problem hiding this comment.
btw, this is not working with experimental .pnp.loader.mjs which is tries to load vscode-eslint-language-server esm format, and fails because of cjs module
There was a problem hiding this comment.
Ah, do you happen to know whether simply adding .pnp.loader.mjs here would do it?
There was a problem hiding this comment.
Yes it would help, but because of this issue it doesn't work, but its not related to this PR
1 task
|
Is this ready for merge? |
williamboman
force-pushed
the
feat/eslint-yarn2-pnp
branch
from
d1ca6f7
to
90dc57c
Compare
Yep! I just tested it again in a PNP workspace, works fine (and doesn't work without this). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://yarnpkg.com/features/pnp
Yarn's PnP feature changes the way packages are installed. Instead of building on the
node_modulesresolution, it introduces a single.pnp.*jsfile in the project. This file is responsible for orchestrating and resolving dependencies. The eslint LSP server will assume that regularnode_modulesresolution applies when locating theeslintpackage - which will not work in Yarn PnP projects.To work around this, Yarn provides the ability to run Node programs in "PnP-compat" mode via
yarn execandyarn node. My understanding is that this simply hooks into therequire()function to resolve modules via PnP instead Node's builtin module resolution.