feat(treesitter): add support for wasm parsers #28415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis6991
force-pushed
the
tswasm
branch
2 times, most recently
from
7264715
to
be7cc1c
Compare
lewis6991
added
DO NOT MERGE
lewis6991
force-pushed
the
tswasm
branch
5 times, most recently
from
c2519a9
to
31f9b03
Compare
clason
reviewed
Apr 21, 2024
lewis6991
force-pushed
the
tswasm
branch
2 times, most recently
from
7b627ac
to
ca9e93d
Compare
dundargoc
reviewed
Apr 22, 2024
lewis6991
commented
Apr 22, 2024
dundargoc
reviewed
Apr 22, 2024
dundargoc
reviewed
Apr 22, 2024
dundargoc
reviewed
Apr 22, 2024
dundargoc
reviewed
Apr 22, 2024
lewis6991
force-pushed
the
tswasm
branch
3 times, most recently
from
9f77fb6
to
2ecad21
Compare
|
Is this something we want to add to |
|
This is done. There are some followup work to be done such as making wasmtime work on debug windows as well as making the importing of the library more robust, but I will punt these tasks to a future date. |
dundargoc
approved these changes
May 8, 2024
justinmk
reviewed
May 14, 2024
| @@ -109,7 +109,14 @@ function M.add(lang, opts) | |||
| path = paths[1] | |||
| end | |||
|
|
|||
| vim._ts_add_language(path, lang, symbol_name) | |||
| if vim.endswith(path, '.wasm') then | |||
There was a problem hiding this comment.
should this be case-insensitive?
justinmk
reviewed
May 14, 2024
| return data; | ||
| } | ||
|
|
||
| static const char *wasmerr_to_str(TSWasmErrorKind werr) |
There was a problem hiding this comment.
should this match the convention of the existing os_strerror, uv_strerror ?
Suggested change
| static const char *wasmerr_to_str(TSWasmErrorKind werr) | |
| static const char *wasm_strerr(TSWasmErrorKind werr) |
justinmk
reviewed
May 14, 2024
justinmk
reviewed
May 14, 2024
dundargoc
force-pushed
the
tswasm
branch
2 times, most recently
from
b3c1cd3
to
1c74802
Compare
dundargoc
force-pushed
the
tswasm
branch
3 times, most recently
from
a3b394e
to
f857699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Treesitter parsers are currently distributed as compiled shared objects which need to be compiled by the users (with the help of nvim-treesitter).
Solution
Allow loading wasm built parsers.
Notes:
ENABLE_WASMTIME) which will be dynamically linked.make CMAKE_EXTRA_FLAGS=-DENABLE_WASMTIME=ON DEPS_CMAKE_FLAGS=-DENABLE_WASMTIME=ONTREE_SITTER_FEATURE_WASMand also requireswasmtimeat build time. So no[uv_]dlopen😢wasmtimehas includes that require C11 (static_assert).